Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean generic_graph.py (part 1) #26624

Closed
dcoudert opened this issue Nov 3, 2018 · 6 comments
Closed

clean generic_graph.py (part 1) #26624

dcoudert opened this issue Nov 3, 2018 · 6 comments
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Nov 3, 2018

Done here:

  • small change in __eq__ to avoid testing twice edge (i, j) if the edge iterator gives edges in random order.
  • remove .vertices() from _bit_vector. This is safe as graph6 and dig6 format only ensure that the string encodes a graph isomorphic to the original graph.
  • some alignments and PEP8.

CC: @tscrim @fchapoton

Component: graph theory

Author: David Coudert

Branch/Commit: 6879bb6

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26624
@dcoudert dcoudert added this to the sage-8.5 milestone Nov 3, 2018
@dcoudert
Copy link
Contributor Author

dcoudert commented Nov 3, 2018

New commits:

6879bb6trac #26624: clean generic_graph.py (part 1)

@dcoudert
Copy link
Contributor Author

dcoudert commented Nov 3, 2018

Commit: 6879bb6

@dcoudert
Copy link
Contributor Author

dcoudert commented Nov 3, 2018

Branch: public/26624_generic_graph_part_1

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:2

ok, then.

@vbraun
Copy link
Member

vbraun commented Nov 7, 2018

Changed branch from public/26624_generic_graph_part_1 to 6879bb6

@vbraun vbraun closed this as completed in af2dac9 Nov 7, 2018
@dcoudert dcoudert mentioned this issue Jun 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @dcoudert