Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: fix doctests in geometry/cone #26636

Closed
fchapoton opened this issue Nov 4, 2018 · 7 comments
Closed

py3: fix doctests in geometry/cone #26636

fchapoton opened this issue Nov 4, 2018 · 7 comments

Comments

@fchapoton
Copy link
Contributor

by sorting

CC: @orlitzky @novoselt

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 65f4f7b

Reviewer: Andrey Novoseltsev

Issue created by migration from https://trac.sagemath.org/ticket/26636

@fchapoton fchapoton added this to the sage-8.5 milestone Nov 4, 2018
@fchapoton
Copy link
Contributor Author

New commits:

65f4f7bpy3: fix doctests in geometry/cone

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26636

@fchapoton
Copy link
Contributor Author

Commit: 65f4f7b

@orlitzky
Copy link
Contributor

orlitzky commented Nov 5, 2018

comment:3

For what it's worth, I believe the non-determinism is due to the following in semigroup_generators:

    gens = set()
    for cone in subcones:
        gens.update(cone.semigroup_generators())
    return tuple(gens)

An ordered tuple or PointCollection (which amounts to the same thing) is always returned, but using set() to eliminate the duplicates makes the order of the tuple itself unreliable.

Andrey will know whether this should be fixed by sorting the output, or by making the output deterministic.

@novoselt
Copy link
Member

novoselt commented Nov 5, 2018

comment:4

Only sorting the output - there is no canonical ordering, so there is no point in wasting time on sorting it always.

@novoselt
Copy link
Member

novoselt commented Nov 5, 2018

Reviewer: Andrey Novoseltsev

@vbraun
Copy link
Member

vbraun commented Nov 7, 2018

Changed branch from u/chapoton/26636 to 65f4f7b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants