Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep cleanup of old integer lists #26661

Closed
fchapoton opened this issue Nov 8, 2018 · 12 comments
Closed

pep cleanup of old integer lists #26661

fchapoton opened this issue Nov 8, 2018 · 12 comments

Comments

@fchapoton
Copy link
Contributor

with no special reason

CC: @tscrim

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: c6eb283

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26661

@fchapoton fchapoton added this to the sage-8.5 milestone Nov 8, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26661

@fchapoton
Copy link
Contributor Author

New commits:

3a928b8pep cleanup of old integer list file.

@fchapoton
Copy link
Contributor Author

Commit: 3a928b8

@embray
Copy link
Contributor

embray commented Nov 8, 2018

comment:2

While you're at it:

diff --git a/src/sage/combinat/integer_list_old.py b/src/sage/combinat/integer_list_old.py
index 280dec5..e028b38 100644
--- a/src/sage/combinat/integer_list_old.py
+++ b/src/sage/combinat/integer_list_old.py
@@ -43,7 +43,7 @@ from sage.misc.stopgap import stopgap
 
 def first(n, min_length, max_length, floor, ceiling, min_slope, max_slope):
     """
-    Returns the lexicographically smallest valid composition of `n`
+    Return the lexicographically smallest valid composition of `n`
     satisfying the conditions.
 
     .. warning::

Shouldn't this be ``n`` with two backticks? Or does our Sphinx configuration recognize function arguments with the default interpreted text role?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 8, 2018

Changed commit from 3a928b8 to c6eb283

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 8, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

c6eb283trac 26661 details

@fchapoton
Copy link
Contributor Author

comment:4

I have made the suggested changes.

@fchapoton
Copy link
Contributor Author

comment:5

Erik ?

@fchapoton
Copy link
Contributor Author

comment:6

please review

@tscrim
Copy link
Collaborator

tscrim commented Nov 17, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Nov 17, 2018

comment:7

LGTM.

@vbraun
Copy link
Member

vbraun commented Nov 19, 2018

Changed branch from u/chapoton/26661 to c6eb283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants