Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove one deprecated function in octave interface #26693

Closed
fchapoton opened this issue Nov 13, 2018 · 8 comments
Closed

remove one deprecated function in octave interface #26693

fchapoton opened this issue Nov 13, 2018 · 8 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

after #21135

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: d1d9fc5

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26693
@fchapoton fchapoton added this to the sage-8.5 milestone Nov 13, 2018
@fchapoton
Copy link
Contributor Author

Commit: a809c5a

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/21135

@fchapoton
Copy link
Contributor Author

New commits:

a809c5aremove one deprecated function in octave interface

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2018

Changed commit from a809c5a to d1d9fc5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

d1d9fc5fix import (remove octave_version)

@tscrim
Copy link
Collaborator

tscrim commented Nov 14, 2018

comment:3

LGTM (assuming green patchbot).

@tscrim
Copy link
Collaborator

tscrim commented Nov 14, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Nov 15, 2018

Changed branch from u/chapoton/21135 to d1d9fc5

@vbraun vbraun closed this as completed in d35c467 Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton