Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fix some doctests in eta products #26698

Closed
fchapoton opened this issue Nov 13, 2018 · 10 comments
Closed

py3: fix some doctests in eta products #26698

fchapoton opened this issue Nov 13, 2018 · 10 comments
Labels
c: python3 p: minor / 4 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 3b6f256

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26698
@fchapoton fchapoton added this to the sage-8.5 milestone Nov 13, 2018
@fchapoton
Copy link
Contributor Author

New commits:

2ee1026py3: fix some doctests in Eta products

@fchapoton
Copy link
Contributor Author

Commit: 2ee1026

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26698

@tscrim
Copy link
Collaborator

tscrim commented Nov 14, 2018

comment:2

I think a faster version of the richcmp test would be to first check if op is not < or >, in which case you should do the equality test for the dicts. That way you can avoid creating the temp object and sorting it as much as possible.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

3b6f256trac 26698 more specific richcmp

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2018

Changed commit from 2ee1026 to 3b6f256

@fchapoton
Copy link
Contributor Author

comment:4

like that ?

@tscrim
Copy link
Collaborator

tscrim commented Nov 16, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Nov 16, 2018

comment:5

Yes, that will be good. Thank you.

@vbraun
Copy link
Member

vbraun commented Nov 18, 2018

Changed branch from u/chapoton/26698 to 3b6f256

@vbraun vbraun closed this as completed in 0d30000 Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton