Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small cleanup for alternating sign matrices #26734

Closed
fchapoton opened this issue Nov 21, 2018 · 7 comments
Closed

small cleanup for alternating sign matrices #26734

fchapoton opened this issue Nov 21, 2018 · 7 comments
Labels
c: combinatorics p: minor / 4 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

  • partial pep
  • remove deprecated stuff
  • other details

CC: @tscrim @jm58660

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 3588506

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26734
@fchapoton fchapoton added this to the sage-8.5 milestone Nov 21, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26734

@fchapoton
Copy link
Contributor Author

Commit: 3588506

@fchapoton
Copy link
Contributor Author

New commits:

3588506cleanup for alternating sign matrices (partial pep, deprecation, other details)

@fchapoton fchapoton changed the title smal cleanup for alternating sign matrices small cleanup for alternating sign matrices Nov 22, 2018
@fchapoton
Copy link
Contributor Author

comment:3

green bot, please review (easy one)

@tscrim
Copy link
Collaborator

tscrim commented Nov 22, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Nov 22, 2018

comment:4

LGTM.

@vbraun
Copy link
Member

vbraun commented Nov 23, 2018

Changed branch from u/chapoton/26734 to 3588506

@vbraun vbraun closed this as completed in 73b2d39 Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton