New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3: caring for structure/ doctests #26768
Comments
New commits:
|
Branch: u/chapoton/26768 |
Commit: |
Reviewer: Travis Scrimshaw |
comment:2
I don't understand why you now get the deprecation warning for that |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
I have instead added the deprecation warning in the doctest. With this change, all doctests in structure/ pass both with py2 and py3. So, even if I do no like at all this mysterious appearance of deprecations, I would rather bear with it right now, in order to make good progress towards python3. |
comment:5
That particular change was a micro-optimization/presentation change (unless I am misunderstanding something), so that is why I suggested a revert. However, since this does work, positive review. |
Changed branch from u/chapoton/26768 to |
all but one
Component: python3
Author: Frédéric Chapoton
Branch/Commit:
f5394d4
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/26768
The text was updated successfully, but these errors were encountered: