Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: caring for structure/ doctests #26768

Closed
fchapoton opened this issue Nov 26, 2018 · 10 comments
Closed

py3: caring for structure/ doctests #26768

fchapoton opened this issue Nov 26, 2018 · 10 comments

Comments

@fchapoton
Copy link
Contributor

all but one

Component: python3

Author: Frédéric Chapoton

Branch/Commit: f5394d4

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26768

@fchapoton fchapoton added this to the sage-8.5 milestone Nov 26, 2018
@fchapoton
Copy link
Contributor Author

New commits:

82f94e1py3: some care for structure/ doctests

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26768

@fchapoton
Copy link
Contributor Author

Commit: 82f94e1

@tscrim
Copy link
Collaborator

tscrim commented Nov 27, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Nov 27, 2018

comment:2

I don't understand why you now get the deprecation warning for that sum. However, since that function is deprecated, I would just revert that change. Once done, you can set a positive review.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 27, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

f5394d4trac 26768 fixing the doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 27, 2018

Changed commit from 82f94e1 to f5394d4

@fchapoton
Copy link
Contributor Author

comment:4

I have instead added the deprecation warning in the doctest.

With this change, all doctests in structure/ pass both with py2 and py3.

So, even if I do no like at all this mysterious appearance of deprecations, I would rather bear with it right now, in order to make good progress towards python3.

@tscrim
Copy link
Collaborator

tscrim commented Nov 27, 2018

comment:5

That particular change was a micro-optimization/presentation change (unless I am misunderstanding something), so that is why I suggested a revert. However, since this does work, positive review.

@vbraun
Copy link
Member

vbraun commented Nov 29, 2018

Changed branch from u/chapoton/26768 to f5394d4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants