Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing some details for elliptic curves over QQ #26783

Closed
fchapoton opened this issue Nov 28, 2018 · 7 comments
Closed

fixing some details for elliptic curves over QQ #26783

fchapoton opened this issue Nov 28, 2018 · 7 comments
Labels
c: elliptic curves p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

main fix: the behaviour of the hidden attribute __torsion_order. It was supposed to be recomputed when calling the method torsion_subgroup. This was not the case when the torsion subgroup was cached.

  • some other cosmetic details

CC: @JohnCremona

Component: elliptic curves

Author: Frédéric Chapoton

Branch/Commit: 7fef710

Reviewer: John Cremona

Issue created by migration from https://trac.sagemath.org/ticket/26783
@fchapoton fchapoton added this to the sage-8.5 milestone Nov 28, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26783

@fchapoton
Copy link
Contributor Author

Commit: 7fef710

@fchapoton
Copy link
Contributor Author

New commits:

7fef710fixing some details in elliptic curves over Q

@JohnCremona
Copy link
Member

comment:2

Looks good to me. And one patchbot is happy -- how many do we need?

@fchapoton
Copy link
Contributor Author

comment:3

one is enough. Please set to positive

@JohnCremona
Copy link
Member

Reviewer: John Cremona

@vbraun
Copy link
Member

vbraun commented Nov 30, 2018

Changed branch from u/chapoton/26783 to 7fef710

@vbraun vbraun closed this as completed in 60be25f Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: elliptic curves p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @JohnCremona @fchapoton