Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing some "import sage" #26793

Closed
fchapoton opened this issue Nov 30, 2018 · 7 comments
Closed

removing some "import sage" #26793

fchapoton opened this issue Nov 30, 2018 · 7 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

because using that does not seem to be a good idea

CC: @jdemeyer @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 55cc8b6

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26793
@fchapoton fchapoton added this to the sage-8.5 milestone Nov 30, 2018
@fchapoton
Copy link
Contributor Author

New commits:

55cc8b6trying to avoid "import sage"

@fchapoton
Copy link
Contributor Author

Commit: 55cc8b6

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26793

@fchapoton
Copy link
Contributor Author

comment:2

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Dec 1, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Dec 1, 2018

comment:3

I agree.

@vbraun
Copy link
Member

vbraun commented Dec 2, 2018

Changed branch from u/chapoton/26793 to 55cc8b6

@vbraun vbraun closed this as completed in b574f16 Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton