Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep8 cleaning in centrality_betweenness and centrality_closeness #26822

Closed
dcoudert opened this issue Dec 4, 2018 · 11 comments
Closed

pep8 cleaning in centrality_betweenness and centrality_closeness #26822

dcoudert opened this issue Dec 4, 2018 · 11 comments
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Dec 4, 2018

We also avoid some calls to .vertices() that where useless

Component: graph theory

Author: David Coudert

Branch/Commit: edd746d

Reviewer: Bryan Gin-ge Chen

Issue created by migration from https://trac.sagemath.org/ticket/26822
@dcoudert dcoudert added this to the sage-8.5 milestone Dec 4, 2018
@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 4, 2018

Commit: a128df2

@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 4, 2018

Branch: public/26822_centralities

@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 4, 2018

New commits:

a128df2trac #26822: pep8 in centrality_betweenness and centrality_closeness

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

2df570ctrac #26822: fix doctest error in centrality_closeness

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2018

Changed commit from a128df2 to 2df570c

@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 5, 2018

comment:3

For directed graphs, no value is returned for vertices with out-degree 0, but a value is returned for vertices with in-degree 0 and out-degree > 0. The doctest is now fixed.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 26, 2019

Changed commit from 2df570c to edd746d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 26, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

edd746dtrac #26822: Merged with 8.7.beta0

@dcoudert dcoudert modified the milestones: sage-8.5, sage-8.7 Jan 26, 2019
@bryangingechen
Copy link
Mannequin

bryangingechen mannequin commented Jan 28, 2019

comment:6

This one looks good too.

@bryangingechen
Copy link
Mannequin

bryangingechen mannequin commented Jan 28, 2019

Reviewer: Bryan Gin-ge Chen

@vbraun
Copy link
Member

vbraun commented Feb 3, 2019

Changed branch from public/26822_centralities to edd746d

@vbraun vbraun closed this as completed in d03b5b8 Feb 3, 2019
This was referenced Jun 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
2 participants
@vbraun @dcoudert