pep8 cleaning in distances methods

[dcoudert]

We do pep8 cleaning in methods all_paths, shortest_path, shortest_path_length, _check_weight_function, shortest_paths, shortest_path_lengths, shortest_path_all_pairs.

Component: graph theory

Author: David Coudert

Branch/Commit: 2ff0fd2

Reviewer: Vincent Klein

Issue created by migration from https://trac.sagemath.org/ticket/26823

[dcoudert]

Branch: public/26823_clean_distance_methods

[dcoudert]

New commits:

9dd97bd

trac #26823: pep8 in distance methods

[dcoudert]

Commit: 9dd97bd

[vinklein]

comment:3

python remark:
I think there is a bad copy-paste line 15709.

        if not self.has_vertex(u):
            raise ValueError("vertex '{}' is not in the (di)graph".format(u))
        if not self.has_vertex(u):
            raise ValueError("vertex '{}' is not in the (di)graph".format(u))

pep8 remarks:

• 1. Missing whitespace around operator:
     l 15278: s=start
• 2. At least two spaces before inline comment:
     l 15289: s = next(act_path_iter[-1]) # try to get the next neighbor/successor, ...

l 15553: if u == v: # to avoid a NetworkX bug

l 15714: # to avoid a NetworkX bug

• 3. Do not assign a lambda expression use a def:
     l 15551, 15724, 15947, 16167, 16450, 16490, 16516: weight_function = lambda e: e[2]

l 15564, 15736, 15949, 16169, 16481: weight_function = lambda e: 1

• 4. Too many blank lines:
     l 15557
• 5. Missing whitespace:
     l 15984: _,pred = ...

l 16492: dist[u],pred[u] = ...

[vinklein]

Reviewer: Vincent Klein

[sagetrac-git]

Changed commit from 9dd97bd to 6c67fc0

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6c67fc0

trac #26823: reviewer's comments

[dcoudert]

comment:7

I have implemented all your comments. Thank you.

[vinklein]

comment:8

You're welcome.

There is one remaining weight_function = lambda e: 1 in shortest_path_all_pairs line 16487.

[sagetrac-git]

Changed commit from 6c67fc0 to 2ff0fd2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2ff0fd2

trac #26823: another lambda

[dcoudert]

comment:10

oups. Fixed.

[vbraun]

Changed branch from public/26823_clean_distance_methods to 2ff0fd2

[embray]

comment:13

This tickets were closed as fixed after the Sage 8.5 release.