Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid using .vertices() in tdlib.pyx #26832

Closed
dcoudert opened this issue Dec 5, 2018 · 7 comments
Closed

avoid using .vertices() in tdlib.pyx #26832

dcoudert opened this issue Dec 5, 2018 · 7 comments
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Milestone
sage-8.6

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Dec 5, 2018

avoid using .vertices() in tdlib.pyx by using a proper mapping. We also do some pep8 cleaning.

Component: graph theory

Author: David Coudert

Branch/Commit: 21e84f3

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26832
@dcoudert dcoudert added this to the sage-8.5 milestone Dec 5, 2018
@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 5, 2018

Branch: public/26832_tdlib

@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 5, 2018

New commits:

c2bff9atrac #26832: avoid using .vertices()
21e84f3trac #26832: pep8 cleaning

@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 5, 2018

Commit: 21e84f3

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:2

ok

@vbraun
Copy link
Member

vbraun commented Dec 23, 2018

Changed branch from public/26832_tdlib to 21e84f3

@vbraun vbraun closed this as completed in cf0b112 Dec 23, 2018
@embray
Copy link
Contributor

embray commented Dec 28, 2018

comment:4

This tickets were closed as fixed after the Sage 8.5 release.

@embray embray modified the milestones: sage-8.5, sage-8.6 Dec 28, 2018
This was referenced Feb 14, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.6
Development

No branches or pull requests
4 participants
@embray @vbraun @fchapoton @dcoudert