Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid using .vertices() in vertex_separation.pyx #26833

Closed
dcoudert opened this issue Dec 5, 2018 · 8 comments
Closed

avoid using .vertices() in vertex_separation.pyx #26833

dcoudert opened this issue Dec 5, 2018 · 8 comments
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Dec 5, 2018

To avoid using .vertices(), we change the default ordering of vertices in FastDiGraph and add it's constructor an optional parameter to specify the mapping integer to vertices.

Component: graph theory

Author: David Coudert

Branch/Commit: a7825df

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26833
@dcoudert dcoudert added this to the sage-8.5 milestone Dec 5, 2018
@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 5, 2018

Commit: 113af6e

@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 5, 2018

Branch: public/26833_vertex_separation

@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 5, 2018

New commits:

113af6etrac #26833: avoid .vertices() in vertex_separation.pyx

@dcoudert dcoudert changed the title avoid using .vertices in vertex_separation.pyx avoid using .vertices() in vertex_separation.pyx Dec 5, 2018
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

a7825dftrac #26833: better use of dense_graph_init to avoid call to .vertices()

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2018

Changed commit from 113af6e to a7825df

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:3

seems to be ok

@vbraun
Copy link
Member

vbraun commented Dec 8, 2018

Changed branch from public/26833_vertex_separation to a7825df

@vbraun vbraun closed this as completed in d8b51a0 Dec 8, 2018
This was referenced Feb 14, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @dcoudert