Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some enhancements to cluster quiver interact #26836

Closed
fchapoton opened this issue Dec 5, 2018 · 12 comments
Closed

some enhancements to cluster quiver interact #26836

fchapoton opened this issue Dec 5, 2018 · 12 comments

Comments

@fchapoton
Copy link
Contributor

  • make it really work on python3

  • auto-reduce the mutation sequence (mu_i is an involution)

  • interactive choice between spring and circular display

  • adjust the vertex colors (more pastel)

CC: @Etn40ff @stumpc5 @tscrim

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 02ce422

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26836

@fchapoton fchapoton added this to the sage-8.5 milestone Dec 5, 2018
@fchapoton
Copy link
Contributor Author

New commits:

7ac68cfsome tiny enhancements to cluster interact

@fchapoton
Copy link
Contributor Author

Commit: 7ac68cf

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26836

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

02ce422some tiny enhancements to cluster interact

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2018

Changed commit from 7ac68cf to 02ce422

@stumpc5
Copy link
Contributor

stumpc5 commented Dec 5, 2018

comment:3

Thanks for taking care of this! I don't have any new version of sage, but I am sure Travis has :-)


New commits:

02ce422some tiny enhancements to cluster interact

@tscrim
Copy link
Collaborator

tscrim commented Dec 6, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Dec 6, 2018

comment:4

LGTM.

@fchapoton
Copy link
Contributor Author

comment:5

thanks, Travis. Maybe you should have asked me to care for the pyflakes plugin warning ?

@tscrim
Copy link
Collaborator

tscrim commented Dec 6, 2018

comment:6

Probably. If you want to quickly fix that, go ahead, and we can reset to positive.

@fchapoton
Copy link
Contributor Author

comment:7

I prefer not to touch anything that is already in positive review.

@vbraun
Copy link
Member

vbraun commented Dec 8, 2018

Changed branch from u/chapoton/26836 to 02ce422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants