New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3: Fix combinat.designs module for python3 (final) #26837
Labels
Milestone
Comments
Branch: u/vklein/26837 |
New commits:
|
This comment has been minimized.
This comment has been minimized.
Commit: |
vinklein
mannequin
changed the title
py3: Fix combinat.designs module for python3
py3: Fix combinat.designs module for python3 (final)
Dec 5, 2018
Reviewer: chapoton |
This comment has been minimized.
This comment has been minimized.
Changed reviewer from chapoton to none |
comment:5
green patchbot => positive review |
Reviewer: Frédéric Chapoton |
comment:6
ok |
comment:7
Merci! |
Changed branch from u/vklein/26837 to |
comment:9
This change doesn't quite work: - self._points = sorted(points)
- if self._points == list(range(len(points))) and all(isinstance(x,(int,Integer)) for x in self._points):
+ # if points are tuple, sort None before int types and str after int types
+ sortkey = lambda e: [(0 if x is None else 2 if isinstance(x, str) else 1, x) for x in e]\
+ if isinstance(e, tuple) else e
+ self._points = sorted(points, key=sortkey) See #26938. |
Changed commit from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Fix the remaining python3 errors in combinat.designs module :
map
usage with list comprehesion. The former map usage resulting in empty lists and therefore multiple errors.IncidenceStructure.__init__
Errors fixed :
CC: @fchapoton
Component: python3
Author: Vincent Klein
Branch:
069a55f
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/26837
The text was updated successfully, but these errors were encountered: