Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some deprecated things in misc and repl and mip #26843

Closed
fchapoton opened this issue Dec 6, 2018 · 17 comments
Closed

remove some deprecated things in misc and repl and mip #26843

fchapoton opened this issue Dec 6, 2018 · 17 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-8.6

Comments

@fchapoton
Copy link
Contributor

after #20602 #21805 #21342

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 658934e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26843
@fchapoton fchapoton added this to the sage-8.5 milestone Dec 6, 2018
@fchapoton
Copy link
Contributor Author

Commit: 909d1ea

@fchapoton
Copy link
Contributor Author

New commits:

909d1earemoving some deprecated stuff after 20602 21805 21342

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26843

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

bf35ed9trac 26843 fixing doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2018

Changed commit from 909d1ea to bf35ed9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2018

Changed commit from bf35ed9 to 1b96a79

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

1b96a79trac 26843 fixing the doc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

d32af75trac 26843 fix pyflakes warnings

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2018

Changed commit from 1b96a79 to d32af75

@tscrim
Copy link
Collaborator

tscrim commented Dec 7, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Dec 7, 2018

comment:5

Green bot => positive review.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

658934eremoving some deprecated stuff after 20602 21805 21342

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2018

Changed commit from d32af75 to 658934e

@fchapoton
Copy link
Contributor Author

comment:7

I had made a mistake in my import removal. Fixed, and launched the bot.

@fchapoton
Copy link
Contributor Author

comment:8

green bot, thanks

@vbraun
Copy link
Member

vbraun commented Dec 23, 2018

Changed branch from u/chapoton/26843 to 658934e

@vbraun vbraun closed this as completed in b17d624 Dec 23, 2018
@embray
Copy link
Contributor

embray commented Dec 28, 2018

comment:10

This tickets were closed as fixed after the Sage 8.5 release.

@embray embray modified the milestones: sage-8.5, sage-8.6 Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-8.6
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @fchapoton