Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: tiny fix for Lie algebras #26845

Closed
fchapoton opened this issue Dec 6, 2018 · 7 comments
Closed

py3: tiny fix for Lie algebras #26845

fchapoton opened this issue Dec 6, 2018 · 7 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

by using an ordered dict

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 6182617

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26845
@fchapoton fchapoton added this to the sage-8.5 milestone Dec 6, 2018
@fchapoton
Copy link
Contributor Author

New commits:

6182617py3: tentative fix in Lie algebras

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26845

@fchapoton
Copy link
Contributor Author

Commit: 6182617

@tscrim
Copy link
Collaborator

tscrim commented Dec 6, 2018

comment:2

I might be slightly inclined to wrapping the doctests with sorted instead, but I don't have a very strong opinion. So if you feel this is the better fix, then you can set a positive review once the patchbot comes back green.

@tscrim
Copy link
Collaborator

tscrim commented Dec 6, 2018

Reviewer: Travis Scrimshaw

@fchapoton
Copy link
Contributor Author

comment:3

Patchbot is green.

The ultimate aim is to make all doctests pass for lie algebras. This is a small positive step, so let us move on.

@vbraun
Copy link
Member

vbraun commented Dec 8, 2018

Changed branch from u/chapoton/26845 to 6182617

@vbraun vbraun closed this as completed in 9b66525 Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton