Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few unused variable #26862

Closed
jm58660 mannequin opened this issue Dec 10, 2018 · 11 comments
Closed

Few unused variable #26862

jm58660 mannequin opened this issue Dec 10, 2018 · 11 comments
Labels
c: combinatorics r: invalid t: enhancement

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Dec 10, 2018

Just tested pyflakes.

Component: combinatorics

Author: Jori Mäntysalo

Branch/Commit: public/ticket/26862 @ 56fefec

Issue created by migration from https://trac.sagemath.org/ticket/26862
@jm58660 jm58660 mannequin added this to the sage-8.5 milestone Dec 10, 2018
@jm58660 jm58660 mannequin added c: combinatorics labels Dec 10, 2018
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 10, 2018

Branch: u/jmantysalo/unused-variables

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 10, 2018

New commits:

fe6d162Unused variables.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 10, 2018

Commit: fe6d162

@jm58660 jm58660 mannequin added the s: needs review label Dec 10, 2018
@fchapoton
Copy link
Contributor

comment:3

will conflict with #26805

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 10, 2018

comment:4

Replying to @fchapoton:

will conflict with #26805

OK.

@jm58660 jm58660 mannequin added s: needs work and removed s: needs review labels Dec 10, 2018
@fchapoton
Copy link
Contributor

Changed commit from fe6d162 to 56fefec

@fchapoton
Copy link
Contributor

New commits:

56fefecMerge branch 'u/jmantysalo/unused-variables' in 8.7.b4

@fchapoton
Copy link
Contributor

Changed branch from u/jmantysalo/unused-variables to public/ticket/26862

@fchapoton
Copy link
Contributor

comment:6

Hmm, the diff is now almost empty, so that I would suggest to just close as invalid...

@fchapoton fchapoton removed this from the sage-8.5 milestone Feb 24, 2019
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Feb 24, 2019

comment:8

Replying to @fchapoton:

Hmm, the diff is now almost empty, so that I would suggest to just close as invalid...

True.

@embray
Copy link
Contributor

embray commented Feb 26, 2019

comment:9

Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.

@embray embray closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics r: invalid t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@embray @fchapoton