Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fix doctests in digraph_generators.py #26871

Closed
dcoudert opened this issue Dec 11, 2018 · 7 comments
Closed

py3: fix doctests in digraph_generators.py #26871

dcoudert opened this issue Dec 11, 2018 · 7 comments
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Milestone
sage-8.6

Comments

@dcoudert
Copy link
Contributor

  • fix method tournaments_nauty using to bytes_to_str
  • fix doctest in method RandomDirectedGNC by avoiding to print the list of edges and testing that the digraph is acyclic instead
  • fix method RandomDirectedGNR that was calling networkx.random_gnc instead of networkx.random_gnr... and then fix the doctests by avoiding to print the list of edges and testing instead that the digraph is acyclic and is a tree

CC: @tscrim @fchapoton

Component: graph theory

Author: David Coudert

Branch/Commit: 2c066f6

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26871
@dcoudert dcoudert added this to the sage-8.5 milestone Dec 11, 2018
@dcoudert
Copy link
Contributor Author

Branch: public/26871_digraph_generators

@dcoudert
Copy link
Contributor Author

Commit: 2c066f6

@dcoudert
Copy link
Contributor Author

New commits:

2c066f6trac #26871: fix digraph generators

@tscrim
Copy link
Collaborator

tscrim commented Dec 12, 2018

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Dec 12, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Dec 23, 2018

Changed branch from public/26871_digraph_generators to 2c066f6

@vbraun vbraun closed this as completed in f638072 Dec 23, 2018
@embray
Copy link
Contributor

embray commented Dec 28, 2018

comment:4

This tickets were closed as fixed after the Sage 8.5 release.

@embray embray modified the milestones: sage-8.5, sage-8.6 Dec 28, 2018
@dcoudert dcoudert mentioned this issue Jun 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.6
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @dcoudert