Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KleshchevPartitions: ensure that _element_constructor_ is a bound method #26878

Closed
jdemeyer opened this issue Dec 11, 2018 · 9 comments
Closed

Comments

@jdemeyer
Copy link

The _element_constructor machinery in Parent has support both for P._element_constructor_ being a bound and an unbound method. However, there is exactly one case where an unbound method occurs and that is for KleshchevPartitions.

It would be good to simplify the _element_constructor handling to always assume a bound method, but then KleshchevPartitions must be fixed.

Depends on #26873

CC: @tscrim

Component: coercion

Author: Jeroen Demeyer

Branch/Commit: 995ca87

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26878

@jdemeyer jdemeyer added this to the sage-8.5 milestone Dec 11, 2018
@jdemeyer
Copy link
Author

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 11, 2018

Commit: 995ca87

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 11, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2431770Remove deprecated code regarding parent initialization
995ca87Use getattr_from_other_class to create a bound method

@jdemeyer
Copy link
Author

Dependencies: #26873

@jdemeyer
Copy link
Author

New commits:

2431770Remove deprecated code regarding parent initialization
995ca87Use getattr_from_other_class to create a bound method

@tscrim
Copy link
Collaborator

tscrim commented Dec 12, 2018

comment:4

Makes sense and LGTM. If a patchbot comes around green, then positive review.

@tscrim
Copy link
Collaborator

tscrim commented Dec 12, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Dec 23, 2018

@embray
Copy link
Contributor

embray commented Dec 28, 2018

comment:7

This tickets were closed as fixed after the Sage 8.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants