New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't mention #940 as a problem anymore #26950
Comments
Branch: u/novoselt/drop940 |
Commit: |
New commits:
|
comment:3
Removing a comment is ok but removing a doctest is not. |
comment:4
There is this test repeated by the patch from #940 later on in the file. |
comment:5
The other doctest is not exactly the same; it is missing the line
|
comment:6
And what exactly is this line testing? That eval works? Isn't it tested by eval itself? In the removed version it is claimed that it works fine, but presumably the other one was taking too much. My understanding is that the problem of #940 was gone and there is a test for it with the reference to that ticket. So I think there should not be a block in the module docstring that specifically says that there is a problem and #940 has to be fixed. |
Reviewer: Frédéric Chapoton |
comment:7
ok, well. Then let it be.. |
comment:8
Thank you! |
Changed branch from u/novoselt/drop940 to |
It was gone, there is a test for it.
CC: @videlec @sagetrac-tmonteil
Component: interfaces
Author: Andrey Novoseltsev
Branch/Commit:
97eb56d
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/26950
The text was updated successfully, but these errors were encountered: