Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage-download-file script is not py3 compatible #26980

Closed
vbraun opened this issue Dec 31, 2018 · 10 comments
Closed

sage-download-file script is not py3 compatible #26980

vbraun opened this issue Dec 31, 2018 · 10 comments

Comments

@vbraun
Copy link
Member

vbraun commented Dec 31, 2018

Traceback (most recent call last):
  File "/var/lib/buildbot/slave/sage_git/build/build/bin/sage-download-file", line 28, in <module>
    run_safe()
  File "/var/lib/buildbot/slave/sage_git/build/build/bin/../sage_bootstrap/download/cmdline.py", line 119, in run_safe
    except StandardError as error:
NameError: name 'StandardError' is not defined

Component: build

Author: Frédéric Chapoton

Branch/Commit: 255816a

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/26980

@vbraun vbraun added this to the sage-8.6 milestone Dec 31, 2018
@fchapoton
Copy link
Contributor

comment:1

fixed


New commits:

ea4e0ectrac 26980 fix script for python3

@fchapoton
Copy link
Contributor

Commit: ea4e0ec

@fchapoton
Copy link
Contributor

Branch: u/chapoton/26980

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@vbraun
Copy link
Member Author

vbraun commented Dec 31, 2018

Changed branch from u/chapoton/26980 to u/vbraun/26980

@vbraun
Copy link
Member Author

vbraun commented Dec 31, 2018

Reviewer: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented Dec 31, 2018

comment:3

LGTM, thanks!

I've added some fixes to the testsuite (cd build && tox) which Eric broke with the sage-system-python addition.... Eventually this will be added as a buildstep to some buildbot.

Please set to positive review...


New commits:

255816aFix tox testsuite for sage_bootstrap

@vbraun
Copy link
Member Author

vbraun commented Dec 31, 2018

Changed commit from ea4e0ec to 255816a

@fchapoton
Copy link
Contributor

comment:4

ok, looks good enough

@vbraun
Copy link
Member Author

vbraun commented Jan 1, 2019

Changed branch from u/vbraun/26980 to 255816a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants