some cleanup around if statements

[fchapoton]

There are a few places with code like

if(something):

This is turned into more pythonic shape.

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 14b42ef

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/26989

[fchapoton]

Commit: 361932f

[fchapoton]

Branch: u/chapoton/26989

[fchapoton]

New commits:

361932f

cleanup around some if statements

[sagetrac-git]

Changed commit from 361932f to 85a22d3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

85a22d3

trac 26989 fix doctests

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

14b42ef

trac 26989 fixing the pyflakes warnings

[sagetrac-git]

Changed commit from 85a22d3 to 14b42ef

[jdemeyer]

comment:5

Why didn't you remove parentheses here?

if (p_up[0] <= p_down[0] or p_down[1] <= p_up[1]):

[jdemeyer]

comment:6

Cython style comment: when comparing C pointers, I prefer is to == to make it clear that we are dealing with object identity (pointers are equal). So I would write if r != currRing: as if r is not currRing:

[jdemeyer]

comment:7

Cython performance comment: product() is not optimized by Cython, so

for (x,y) in product(range(n),range(m)):

is a lot slower than a nested loop

cdef Py_ssize_t x, y
for x in range(n):
    for y in range(m):

I'm not saying that this is necessarily a big problem here, but I thought I should mention it for future reference.

[jdemeyer]

Reviewer: Jeroen Demeyer

[embray]

comment:9

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

[vbraun]

Changed branch from u/chapoton/26989 to 14b42ef