Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sage.schemes.elliptic_curves.padics from documentation #27017

Closed
jdemeyer opened this issue Jan 4, 2019 · 7 comments
Closed

Remove sage.schemes.elliptic_curves.padics from documentation #27017

jdemeyer opened this issue Jan 4, 2019 · 7 comments
Labels
c: documentation p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@jdemeyer
Copy link

jdemeyer commented Jan 4, 2019

The file src/sage/schemes/elliptic_curves/padics.py contains only methods which are imported in src/sage/schemes/elliptic_curves/ell_rational_field.py

So there is no reason for this module to be documented.

CC: @kwankyu

Component: documentation

Author: Jeroen Demeyer

Branch/Commit: d877ad1

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/27017
@jdemeyer jdemeyer added this to the sage-8.6 milestone Jan 4, 2019
@jdemeyer
Copy link
Author

jdemeyer commented Jan 4, 2019

Branch: u/jdemeyer/remove_sage_schemes_elliptic_curves_padics_from_documentation

@jdemeyer
Copy link
Author

jdemeyer commented Jan 4, 2019

New commits:

d877ad1Remove sage.schemes.elliptic_curves.padics from documentation

@jdemeyer
Copy link
Author

jdemeyer commented Jan 4, 2019

Commit: d877ad1

@kwankyu
Copy link
Collaborator

kwankyu commented Jan 4, 2019

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Jan 4, 2019

comment:3

This change has zero possibility to break anything. So positive review!

@embray
Copy link
Contributor

embray commented Jan 15, 2019

comment:4

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

@embray embray modified the milestones: sage-8.6, sage-8.7 Jan 15, 2019
@vbraun
Copy link
Member

vbraun commented Jan 22, 2019

Changed branch from u/jdemeyer/remove_sage_schemes_elliptic_curves_padics_from_documentation to d877ad1

@vbraun vbraun closed this as completed in e60f32b Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
4 participants
@embray @vbraun @kwankyu @jdemeyer