Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CombinatorialPolyhedron: Check input on errors. #27087

Open
kliem opened this issue Jan 21, 2019 · 1 comment
Open

CombinatorialPolyhedron: Check input on errors. #27087

kliem opened this issue Jan 21, 2019 · 1 comment

Comments

@kliem
Copy link
Contributor

kliem commented Jan 21, 2019

There are a few mistakes one can easily make, when creating a CombinatorialPolyhedron from a list of facets or an incidence matrix. It would be nice to give warnings/error messages about them. Such mistakes can be:

  • Not specifying the nr of lines in an unbounded Polyhedron (one knows it is the case, when the vertices in their facet reprsentation are a subset from each other).
  • Giving one facet that is actually a list of all vertices.
  • Giving an incompatible list of names for vertices and/or facets (maybe too long or too short).
  • Checking the facets for inclusions.

Maybe it makes sense to initialize the CombinatorialPolyehdron in C and then do any error checking in terms of inclusion tests. Then a correct input will still be about the same speed and an incorrect input slower.

One could give a warning as "The Polyhedron appears to be unbounded, assuming n number of lines".

Depends on #26887

Component: geometry

Issue created by migration from https://trac.sagemath.org/ticket/27087

@kliem kliem added this to the sage-8.7 milestone Jan 21, 2019
@embray
Copy link
Contributor

embray commented Mar 25, 2019

comment:1

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants