Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fix some doctests in interacts #27116

Closed
fchapoton opened this issue Jan 25, 2019 · 8 comments
Closed

py3: fix some doctests in interacts #27116

fchapoton opened this issue Jan 25, 2019 · 8 comments
Labels
c: python3 r: invalid t: enhancement

Comments

@fchapoton
Copy link
Contributor

by wrapping range with list

Component: python3

Author: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/27116
@fchapoton fchapoton added this to the sage-8.7 milestone Jan 25, 2019
@fchapoton
Copy link
Contributor Author

New commits:

76afd5fpy3: fix some doctests in interacts library (range)

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27116

@fchapoton
Copy link
Contributor Author

Commit: 76afd5f

@jdemeyer
Copy link

comment:2

As you can probably guess, I don't like this change. It's again one of these cases where range(n) should just work and we shouldn't "fix" the code by using list(range(n)).

See #27117 for a real fix.

@fchapoton
Copy link
Contributor Author

comment:4

ok, the doctests in this file now pass.

please close as invalid

@fchapoton
Copy link
Contributor Author

Changed branch from u/chapoton/27116 to none

@fchapoton
Copy link
Contributor Author

Changed commit from 76afd5f to none

@fchapoton fchapoton removed this from the sage-8.7 milestone Feb 18, 2019
@embray
Copy link
Contributor

embray commented Feb 26, 2019

comment:5

Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.

@embray embray closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 r: invalid t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@embray @jdemeyer @fchapoton