Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some duplicate imports #27120

Closed
fchapoton opened this issue Jan 25, 2019 · 16 comments
Closed

remove some duplicate imports #27120

fchapoton opened this issue Jan 25, 2019 · 16 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-8.7

Comments

@fchapoton
Copy link
Contributor

found by lgtm

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 14938c7

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27120
@fchapoton fchapoton added this to the sage-8.7 milestone Jan 25, 2019
@fchapoton
Copy link
Contributor Author

Commit: 7447885

@fchapoton
Copy link
Contributor Author

New commits:

7447885remove some duplicate imports (found by lgtm)

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27120

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 25, 2019

Changed commit from 7447885 to 5bf8858

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 25, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5bf8858remove some duplicate imports (found by lgtm)

@tscrim
Copy link
Collaborator

tscrim commented Jan 25, 2019

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jan 25, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jan 27, 2019

comment:4

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 27, 2019

Changed commit from 5bf8858 to 1fadee1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 27, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

1fadee1Merge branch 'u/chapoton/27120' in 8.7.b1

@fchapoton
Copy link
Contributor Author

comment:6

merged (no conflict)

@vbraun
Copy link
Member

vbraun commented Feb 3, 2019

comment:8

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 3, 2019

Changed commit from 1fadee1 to 14938c7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 3, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

14938c7Merge branch 'u/chapoton/27120' in 8.7.b2

@fchapoton
Copy link
Contributor Author

comment:10

fixed

@vbraun
Copy link
Member

vbraun commented Feb 5, 2019

Changed branch from u/chapoton/27120 to 14938c7

@vbraun vbraun closed this as completed in ea7cdd8 Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton