Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UI for Python 3 Sage doctesting #27150

Closed
videlec opened this issue Jan 27, 2019 · 12 comments
Closed

Better UI for Python 3 Sage doctesting #27150

videlec opened this issue Jan 27, 2019 · 12 comments

Comments

@videlec
Copy link
Contributor

videlec commented Jan 27, 2019

running sage -t in a Python 2 or Python 3 installation of Sage results in a seemingly wrong set of --optional flags

$ sage -t XXX
...
Using --optional=dochtml,memlimit,mpir,python2,sage
...

In a Python 2 installation the py2 should be there (and the python2 appearing because of a is quite weird). While on Python 3 it should be py3.

See also this sage-devel thread.

CC: @fchapoton

Component: doctest framework

Issue created by migration from https://trac.sagemath.org/ticket/27150

@videlec videlec added this to the sage-8.7 milestone Jan 27, 2019
@videlec

This comment has been minimized.

@jdemeyer
Copy link

comment:2

It's just a UI issue. Everything is behaving as it should be...

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Fix Python 3 Sage doctesting Better UI for Python 3 Sage doctesting Jan 27, 2019
@videlec
Copy link
Contributor Author

videlec commented Jan 27, 2019

comment:3

I don't agree: python2 doctesting is also broken. The py2 tag is not in the optional list and hence ignored.

@jdemeyer
Copy link

comment:4

Are you really sure?

@videlec
Copy link
Contributor Author

videlec commented Jan 27, 2019

comment:5

It depends what you mean by "normal". More precisely:

  • the optional py2/py3 do not appear on the command line due to the filtering in line 1018 of doctest/control.py
return ",".join(sorted(tags - auto_optional_tags))
  • the python2 appears in the list because python2 is an optional package (is it installed under any circumstances?)

Both look quite artificial to me.

Conclusion: doctests are not broken - behavior is very confusing.

@jdemeyer
Copy link

comment:6

Everything is working as designed but the design might be confusing. That's why I said that it's an UI issue.

@videlec
Copy link
Contributor Author

videlec commented Jan 27, 2019

comment:7

@jdemeyer: Do you know whether python2 is always installed? (it got installed on my fresh py3 build). Why is it optional?

@embray
Copy link
Contributor

embray commented Mar 25, 2019

comment:8

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

@embray embray modified the milestones: sage-8.7, sage-8.8 Mar 25, 2019
@embray
Copy link
Contributor

embray commented Jun 14, 2019

comment:9

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

@embray embray removed this from the sage-8.8 milestone Jun 14, 2019
@mkoeppe
Copy link
Member

mkoeppe commented Sep 7, 2021

comment:11

Outdated, should close

@fchapoton
Copy link
Contributor

comment:13

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants