New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3: fix doctests in vertex_separation.pyx #27151
Comments
Commit: |
Reviewer: Vincent Klein |
comment:2
Hi ! I don't think all the
give the same results in both py2 and py3. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
Very good idea. Thanks. I have changed 3 doctests. One pair of py2/py3 tags remains as I don't know how to avoid it. |
comment:5
Ok this looks fine. |
Changed branch from u/dcoudert/27151_vertex_separation to |
Several failing doctests were caused by the impossibility to sort of list of
Set
(already in Python2).Since path decomposition is a graph whose vertices are
Set
, we get different results in py2 and py3.=> we mark doctests as
# py2
and# py3
.Some doctests were due to a
max(None, <number>)
. With a proper initialization of thecut_off
variable, we don't have this issue anymore.Another doctest is fixed in #27027.
Component: graph theory
Author: David Coudert
Branch/Commit:
206f496
Reviewer: Vincent Klein
Issue created by migration from https://trac.sagemath.org/ticket/27151
The text was updated successfully, but these errors were encountered: