Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: fix doctests in hyperbolicity and graph_coloring #27160

Closed
dcoudert opened this issue Jan 28, 2019 · 13 comments
Closed

py3: fix doctests in hyperbolicity and graph_coloring #27160

dcoudert opened this issue Jan 28, 2019 · 13 comments

Comments

@dcoudert
Copy link
Contributor

  • hyperbolicity: we avoid sorting vertex ids before returning the certificate, and we sort these ids in the doctests.
  • graph_coloring: we sort the output of some doctests

Component: graph theory

Author: David Coudert

Branch/Commit: c3678ad

Reviewer: Jean-Florent Raymond

Issue created by migration from https://trac.sagemath.org/ticket/27160

@dcoudert dcoudert added this to the sage-8.7 milestone Jan 28, 2019
@dcoudert
Copy link
Contributor Author

New commits:

7dd655fhyperbolicity: mark doctest as py2 and py3
4784cc2graph_coloring: mark doctest as py2 and py3

@dcoudert
Copy link
Contributor Author

@dcoudert
Copy link
Contributor Author

Commit: 4784cc2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 16, 2019

Changed commit from 4784cc2 to 2490bc9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 16, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

0cccb17trac #27160: Merged with 8.7.beta4
5e58fe7trac #27160: avoid sorting vertex ids when returning certificate
2490bc9trac #27160: avoid tag py2 and py3 in graph_coloring

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 16, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

c3678adtrac #27160: avoid another py2/py3 tag in graph_coloring

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 16, 2019

Changed commit from 2490bc9 to c3678ad

@dcoudert
Copy link
Contributor Author

comment:4

I changed the proposed fixes to avoid # py2 and #py 3 tags.

  • hyperbolicity: it is more robust to avoid sorting vertex ids of the certificate before returning it, and to sort these ids in the doctests
  • graph_coloring: we now sort the output of some doctests

@dcoudert

This comment has been minimized.

@jfraymond
Copy link

comment:5

Note that the lines you edited about approximation of hyperbolicity for grids an cycles now go over 80 characters. (also true for other lines of both files, but outside of the aim of this ticket)

Is it a problem? If not I am fine with the patch.

@dcoudert
Copy link
Contributor Author

comment:6

It's not a problem (at least for me).

@jfraymond
Copy link

Reviewer: Jean-Florent Raymond

@vbraun
Copy link
Member

vbraun commented Feb 23, 2019

Changed branch from u/dcoudert/27160_hyperbolicity_and_graph_coloring to c3678ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants