Move file src/bin/sage-maxima.lisp, used by sage at import time, to live inside the package

[embray]

Non-binary files that are part of the sage sources and needed by the sage package at import time should be installed in the package, using package_data in setup.py. See e.g. #27040 comment:48

Depends on #21559

CC: @kiwifb @timokau @jhpalmieri @fchapoton

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: da05b3c

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/27171

[jdemeyer]

comment:3

(edit: never mind)

[jdemeyer]

comment:4

Replying to embray:

If it's needed by the sage Python package to work then it should just be installed inside the package (e.g. as package_data in setup.py)

Why should it be installed like that?

I'm not against moving the specific file sage-maxima.lisp, but you seem to imply a more general rule here that Python packages should never access files outside of their own package (or something like that?).

[embray]

comment:6

Replying to @jdemeyer:

Replying to embray:

If it's needed by the sage Python package to work then it should just be installed inside the package (e.g. as package_data in setup.py)

Why should it be installed like that?

I'm not against moving the specific file sage-maxima.lisp, but you seem to imply a more general rule here that Python packages should never access files outside of their own package (or something like that?).

That's definitely not what I'm saying, though I can see where you get the implication.

This is definitely not a rule in case of files that are not part of Sage, which may come from other packages or be overridden in some way by downstream packagers or by users. In those cases we want an option, with some reasonable default, for where to find that file.

In this case, if I understand correctly, it's just Maxima startup code very specific to Sage's Maxima interface. So there's no reason for it to live anywhere else outside the sage package, and that also makes the question of "where to find it" much simpler, because it's just relative to the package's installation path. And it certainly doesn't belong in any bin/.

Did the same with sage.gaprc in sage.libs.gap.

[embray]

comment:7

Removing most of the rest of my open tickets out of the 8.7 milestone, which should be closed.

[mkoeppe]

Dependencies: #21559

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Branch: u/mkoeppe/move_file_src_bin_sage_maxima_lisp__used_by_sage_at_import_time__to_live_inside_the_package

[mkoeppe]

comment:12

1 commit on top of #21559.

---

Last 10 new commits:

4a3d36e	Move 'sage -app' back to src/bin/sage
3a0193c	src/bin/sage: Remove handling of 'sage -axiom'
6b04075	Merge branch 't/29111/specify_a_subset_of_sage_command_line_options_that_are_supported_by_sagelib___rather_than_sage_the_distribution' into t/21559/change-src-bin-installation
9c7116b	src/bin/sage-list-optional, sage-list-experimental, sage-list-standard: Remove deprecated scripts
831cc09	Merge branch 't/29920/remove_deprecated_scripts_sage_list_optional__sage_list_experimental__sage_list_standard' into t/21559/change-src-bin-installation
a56dc35	Merge tag '9.2.beta1' into t/29702/public/move_all_code_from_src_setup_py__src_fpickle_setup_py_to_sage_setup
e3eca85	Merge branch 'public/move_all_code_from_src_setup_py__src_fpickle_setup_py_to_sage_setup' of git://trac.sagemath.org/sage into t/21559/change-src-bin-installation
7d29141	src/setup.py: Do not install removed script sage-rsyncdist
39cb52a	Merge branch 't/21559/change-src-bin-installation' into t/27171/move_file_src_bin_sage_maxima_lisp__used_by_sage_at_import_time__to_live_inside_the_package
da05b3c	src/bin/sage-maxima.lisp: Move inside package, install as package_data

[mkoeppe]

Commit: da05b3c

[kiwifb]

Reviewer: François Bissey

[kiwifb]

comment:13

This is sorely needed. I follows the model of other packages for which it was already done. I want this in. LGTM.

[mkoeppe]

comment:14

Thanks!

[vbraun]

Changed branch from u/mkoeppe/move_file_src_bin_sage_maxima_lisp__used_by_sage_at_import_time__to_live_inside_the_package to da05b3c