Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sagenb to version 1.1.2 #27200

Closed
dimpase opened this issue Feb 1, 2019 · 10 comments
Closed

update sagenb to version 1.1.2 #27200

dimpase opened this issue Feb 1, 2019 · 10 comments

Comments

@dimpase
Copy link
Member

dimpase commented Feb 1, 2019

update needed by new sphinx 1.8.3 on #26451, in particular,
plus other improvements and fixes

tarball: https://github.com/sagemath/sagenb/releases/download/1.1.2/sagenb-1.1.2.tar.bz2

Component: notebook

Author: Dima Pasechnik

Branch/Commit: f539f9b

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/27200

@dimpase dimpase added this to the sage-8.7 milestone Feb 1, 2019
@dimpase
Copy link
Member Author

dimpase commented Feb 1, 2019

Commit: f539f9b

@dimpase
Copy link
Member Author

dimpase commented Feb 1, 2019

Branch: u/dimpase/packages/sagenb112

@dimpase
Copy link
Member Author

dimpase commented Feb 1, 2019

New commits:

f539f9bbump up to 1.1.2

@kiwifb
Copy link
Member

kiwifb commented Feb 1, 2019

comment:2

Question: Does it need sphinx 1.8.3+ or is it fine to also use with sphinx 1.7.x?

@jhpalmieri
Copy link
Member

comment:3

I don't see why it would need Sphinx 1.8.3. The only change relevant to #26451 (the new sphinx) was to replace SageNB's sphinxify to just use sage.misc.sphinxify. So SageNB should remain compatible with whatever the Sage library is using, rather than having code duplication (and code divergence) between the two.

In any case, I'm building and running doctests now.

@dimpase
Copy link
Member Author

dimpase commented Feb 1, 2019

comment:4

it works with version 1.7.6 sphinx too.

@jhpalmieri
Copy link
Member

comment:5

All tests pass for me with sphinx 1.7.6 and sphinx 1.8.3. The legacy notebook appears to work, and docstrings look nice, so I think the sphinxify function is working properly.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:7

Is there anything else that I should test? Other changes from the sagenb side of things?

@vbraun
Copy link
Member

vbraun commented Feb 4, 2019

Changed branch from u/dimpase/packages/sagenb112 to f539f9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants