-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update sagenb to version 1.1.2 #27200
Comments
Commit: |
Branch: u/dimpase/packages/sagenb112 |
New commits:
|
comment:2
Question: Does it need sphinx 1.8.3+ or is it fine to also use with sphinx 1.7.x? |
comment:3
I don't see why it would need Sphinx 1.8.3. The only change relevant to #26451 (the new sphinx) was to replace SageNB's sphinxify to just use In any case, I'm building and running doctests now. |
comment:4
it works with version 1.7.6 sphinx too. |
comment:5
All tests pass for me with sphinx 1.7.6 and sphinx 1.8.3. The legacy notebook appears to work, and docstrings look nice, so I think the sphinxify function is working properly. |
Reviewer: John Palmieri |
comment:7
Is there anything else that I should test? Other changes from the sagenb side of things? |
Changed branch from u/dimpase/packages/sagenb112 to |
update needed by new sphinx 1.8.3 on #26451, in particular,
plus other improvements and fixes
tarball: https://github.com/sagemath/sagenb/releases/download/1.1.2/sagenb-1.1.2.tar.bz2
Component: notebook
Author: Dima Pasechnik
Branch/Commit:
f539f9b
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/27200
The text was updated successfully, but these errors were encountered: