Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplicial complexes: correct the documentation #27211

Closed
jhpalmieri opened this issue Feb 4, 2019 · 13 comments
Closed

Simplicial complexes: correct the documentation #27211

jhpalmieri opened this issue Feb 4, 2019 · 13 comments

Comments

@jhpalmieri
Copy link
Member

The documentation for simplicial complexes is outdated: it should say that the vertex set is determined automatically from the facets (as their union).

Component: algebraic topology

Keywords: simplicial complex

Author: John Palmieri

Branch/Commit: 6ae1ee3

Reviewer: Darij Grinberg

Issue created by migration from https://trac.sagemath.org/ticket/27211

@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/simplicial-docs

@jhpalmieri
Copy link
Member Author

Commit: 15ee788

@jhpalmieri
Copy link
Member Author

New commits:

15ee788trac 27211: in a simplicial complex, the vertex set is determined

@darijgr
Copy link
Contributor

darijgr commented Feb 4, 2019

comment:3
+   automatically: `V` is defined to be the union of the sets `K`. So

->

+   automatically: `V` is defined to be the union of the sets in `K`. So

===

+simplicial complex, specify its *facets*: the maximal subsets (with
+respect to inclusion) of the vertex set. Each facet can be specifed as

->

+simplicial complex, specify its *facets*: the maximal subsets (with
+respect to inclusion) of the vertex set that belong to `K`. Each facet can be specifed as

===
Other than this, LGTM if the doc compiles (I don't have Sage installed, so I can't check) and if your claim about maximal_faces being a number is true (is there a doctest?).

@jhpalmieri
Copy link
Member Author

comment:4

Lines 980-981:

            sage: SimplicialComplex([2])
            Simplicial complex with vertex set (0, 1, 2) and facets {(0, 1, 2)}

@darijgr
Copy link
Contributor

darijgr commented Feb 4, 2019

comment:5

Ah, perfect.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 4, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6ae1ee3trac 27211: in a simplicial complex, the vertex set is determined

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 4, 2019

Changed commit from 15ee788 to 6ae1ee3

@jhpalmieri
Copy link
Member Author

comment:7

I made the other changes, too.

@darijgr
Copy link
Contributor

darijgr commented Feb 5, 2019

Reviewer: Darij Grinberg

@darijgr
Copy link
Contributor

darijgr commented Feb 5, 2019

comment:8

LGTM, thanks!

@darijgr
Copy link
Contributor

darijgr commented Feb 5, 2019

Changed keywords from none to simplicial complex

@vbraun
Copy link
Member

vbraun commented Feb 8, 2019

Changed branch from u/jhpalmieri/simplicial-docs to 6ae1ee3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants