Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fix doctests in generic_graph (part 8) -- coarsest_equitable_refinement #27244

Closed
dcoudert opened this issue Feb 9, 2019 · 6 comments
Closed

py3: fix doctests in generic_graph (part 8) -- coarsest_equitable_refinement #27244

dcoudert opened this issue Feb 9, 2019 · 6 comments
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Feb 9, 2019

We fix a failing doctest with py3 and

  • change a test using sorted with a test using set. More robust
  • clean the creation of mappings vertex to int and int to vertex
  • speed up the addition of edges to the sparse/dense graph

Component: graph theory

Author: David Coudert

Branch/Commit: 87ee62f

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/27244
@dcoudert dcoudert added this to the sage-8.7 milestone Feb 9, 2019
@dcoudert
Copy link
Contributor Author

dcoudert commented Feb 9, 2019

Branch: u/dcoudert/27244_coarsest_equitable_refinement

@dcoudert
Copy link
Contributor Author

dcoudert commented Feb 9, 2019

New commits:

87ee62ftrac #27244: some care in coarsest_equitable_refinement

@dcoudert
Copy link
Contributor Author

dcoudert commented Feb 9, 2019

Commit: 87ee62f

@dcoudert dcoudert changed the title py3: some care in coarsest_equitable_refinement py3: fix doctests in generic_graph (part 8) -- coarsest_equitable_refinement Feb 9, 2019
@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:3

ok

@vbraun
Copy link
Member

vbraun commented Feb 11, 2019

Changed branch from u/dcoudert/27244_coarsest_equitable_refinement to 87ee62f

@vbraun vbraun closed this as completed in c632cec Feb 11, 2019
@dcoudert dcoudert mentioned this issue Jun 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @dcoudert