Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpylll: add patch for Cython 3.0 #27251

Closed
jdemeyer opened this issue Feb 10, 2019 · 11 comments
Closed

fpylll: add patch for Cython 3.0 #27251

jdemeyer opened this issue Feb 10, 2019 · 11 comments

Comments

@jdemeyer
Copy link

Add this patch to fpylll to make it compatible with Cython master. The default value for language_level has changed, so the language_level is best specified explicitly.

This makes absolutely no difference with Cython 0.29.x, so it doesn't affect distributions.

The patch just makes it possible to compile Sage with Cython master (something that I regularly do when contributing to Cython).

Upstream: Fixed upstream, but not in a stable release.

CC: @malb

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: 5eee850

Reviewer: Martin Albrecht

Issue created by migration from https://trac.sagemath.org/ticket/27251

@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

New commits:

de93a45fpylll: add patch for Cython 3

@jdemeyer
Copy link
Author

Commit: de93a45

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 10, 2019

Changed commit from de93a45 to 5eee850

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 10, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5eee850fpylll: add patch for Cython 3

@malb
Copy link
Member

malb commented Feb 11, 2019

comment:5

Thanks. I need to cut a new release for this.

@malb
Copy link
Member

malb commented Feb 11, 2019

Upstream: Fixed upstream, but not in a stable release.

@vbraun
Copy link
Member

vbraun commented Feb 11, 2019

comment:6

Reviewer name is missing...

@jdemeyer
Copy link
Author

Reviewer: Martin Albrecht

@malb
Copy link
Member

malb commented Feb 11, 2019

comment:8

Sorry! I'm getting rusty at this.

@vbraun
Copy link
Member

vbraun commented Feb 14, 2019

Changed branch from u/jdemeyer/fpylll__add_patch_for_cython_3_0 to 5eee850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants