Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frenchism (typos): "representative" should be used instead of "representant" #27291

Closed
falque mannequin opened this issue Feb 15, 2019 · 33 comments
Closed

Frenchism (typos): "representative" should be used instead of "representant" #27291

falque mannequin opened this issue Feb 15, 2019 · 33 comments

Comments

@falque
Copy link
Mannequin

falque mannequin commented Feb 15, 2019

In many places, "representant" is used instead of "representative".

Component: graph theory

Keywords: typo

Author: Prajjwal Jha

Branch: fe55aa0

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/27291

@falque falque mannequin added this to the sage-8.7 milestone Feb 15, 2019
@falque falque mannequin added p: major / 3 labels Feb 15, 2019
@JhaPrajjwal
Copy link

comment:2

NO branch is associated with this. How do I push my changes from the local branch?.

@fchapoton
Copy link
Contributor

comment:3
  • push your local branch to git.sagemath.org or trac.sagemath.org
  • fill the branch name in the ticket description here

@JhaPrajjwal
Copy link

@JhaPrajjwal
Copy link

@fchapoton
Copy link
Contributor

comment:6

your branch name should probably use your login name "gh-JhaPrajjwal"

@fchapoton
Copy link
Contributor

comment:7

did you manage to push a branch ?

@JhaPrajjwal
Copy link

comment:8

I need a trac account. I had requested for it about 2 days ago.

@fchapoton
Copy link
Contributor

comment:9

No, you do not need an account, I do not think so.

http://doc.sagemath.org/html/en/developer/trac.html#obtaining-an-account

If you know how to use "git" (and not our optional custom plugin called "git trac"), then you can just push with your github login.

Something like

git push trac HEAD:u/gh-JhaPrajjwal/mybranchname

should just work.

@JhaPrajjwal
Copy link

comment:10

In that case ,I recieve this error:

git@trac.sagemath.org: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@JhaPrajjwal
Copy link

Changed branch from u/JhaPrajjwal/Corrected to none

@fchapoton
Copy link
Contributor

comment:12

you need to set up your public key inside trac, as explained below in the same page:

http://doc.sagemath.org/html/en/developer/trac.html

@JhaPrajjwal
Copy link

Commit: 76683a7

@JhaPrajjwal
Copy link

Branch: u/gh-JhaPrajjwal/sage_branch

@JhaPrajjwal
Copy link

New commits:

76683a7Changed "representant" to "Representative"

@JhaPrajjwal
Copy link

comment:15

Can you check now?
And Thankyou for your help chapoton.

@fchapoton
Copy link
Contributor

comment:16

Good. Now there is a branch to look at.

But your branch contains a bad file: octave-workspace

@fchapoton
Copy link
Contributor

comment:17

a suggestion (for your next ticket): give your branches some name that either contains the ticket number or describes what the branch does

@JhaPrajjwal
Copy link

comment:18

Replying to @fchapoton:

Good. Now there is a branch to look at.

But your branch contains a bad file: octave-workspace

What should I do about it?

@JhaPrajjwal
Copy link

comment:19

Replying to @fchapoton:

a suggestion (for your next ticket): give your branches some name that either contains the ticket number or describes what the branch does

Okay!

@fchapoton
Copy link
Contributor

comment:20

Replying to @JhaPrajjwal:

Replying to @fchapoton:

Good. Now there is a branch to look at.

But your branch contains a bad file: octave-workspace

What should I do about it?

Well, make a branch where this file is not added, and push it here...

@JhaPrajjwal
Copy link

Changed branch from u/gh-JhaPrajjwal/sage_branch to u/gh-JhaPrajjwal/27291

@fchapoton
Copy link
Contributor

comment:22

still the same problem. You can click on the Branch: field in the ticket description to see the bad file that you are adding.

I suggest "git rm octave-workspace", then "commit", then "rebase -i develop" to squash the commits, then "push -f"

@fchapoton
Copy link
Contributor

comment:23

Are you Justine Falque or Jha Prajjwal ? Please fix the Author fullname: field in the ticket description, if necessary.

@JhaPrajjwal
Copy link

Changed author from Justine Falque to Jha Prajjwal

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 6, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

fe55aa0removed octave-workspace

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 6, 2019

Changed commit from 76683a7 to fe55aa0

@JhaPrajjwal
Copy link

comment:26

Is it okay now?

@fchapoton
Copy link
Contributor

comment:27

ok, thanks

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Mar 7, 2019

Changed branch from u/gh-JhaPrajjwal/27291 to fe55aa0

@slel
Copy link
Member

slel commented Nov 11, 2019

comment:29

At #18855 you put "Prajjwal Jha" as author name,
and here you put "Jha Prajjwal". Would you mind
changing one or the other to make it consistent?

@slel
Copy link
Member

slel commented Nov 11, 2019

Changed commit from fe55aa0 to none

@mkoeppe
Copy link
Member

mkoeppe commented Jun 6, 2020

Changed author from Jha Prajjwal to Prajjwal Jha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants