Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cubic Braid Groups #27302

Closed
soehms opened this issue Feb 16, 2019 · 58 comments
Closed

Cubic Braid Groups #27302

soehms opened this issue Feb 16, 2019 · 58 comments

Comments

@soehms
Copy link
Member

soehms commented Feb 16, 2019

This ticket implements a new class to work with factor groups of the Artin braid groups having order three on the braid generators.

CC: @tscrim

Component: group theory

Keywords: braid groups, complex reflection groups

Author: Sebastian Oehms

Branch/Commit: 9fdafdd

Reviewer: Travis Scrimshaw, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/27302

@soehms soehms added this to the sage-8.7 milestone Feb 16, 2019
@soehms
Copy link
Member Author

soehms commented Feb 16, 2019

Branch: u/soehms/cubic_braid_group_27302

@soehms
Copy link
Member Author

soehms commented Feb 16, 2019

Commit: 756a7bb

@soehms
Copy link
Member Author

soehms commented Feb 16, 2019

New commits:

0133335implement subgroup / ambient methods for MatrixGroup_base
747bc16removed unused keyword
d36aeb8Merge branch 'u/soehms/matrix_groups_subgroups-25894' of git://trac.sagemath.org/sage into cubic_braid_group
756a7bb27302: initial version

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 9, 2019

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

80aabe625894: implement reviewers suggestions
1997ad725894: missing long-doctest fixed, as well
49a04af25894: restore lost changes
c7cb49fMerge branch 'u/soehms/matrix_groups_subgroups-25894' of git://trac.sagemath.org/sage into matrix_group_subgroups_25894
0aec3ccchange representation strings according to reviewers suggestion
455bd17fixing further doctests
c1280b925894: corrections on doctest layout
ea70462Merge commit 'c1280b9fbd954c5f43be122cafd4606872ed353c' of git://trac.sagemath.org/sage into cubic_braid_group_27302
b29a9fcMerge branch 'u/soehms/cubic_braid_group_27302' of git://trac.sagemath.org/sage into cubic_braid_group_27302
623e14bPEP8 adaptions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 9, 2019

Changed commit from 756a7bb to 623e14b

@embray
Copy link
Contributor

embray commented Mar 25, 2019

comment:4

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

@embray embray modified the milestones: sage-8.7, sage-8.8 Mar 25, 2019
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 29, 2019

Changed commit from 623e14b to 6b638b4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 29, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

6b638b4Merge branch 'u/soehms/cubic_braid_group_27302' of git://trac.sagemath.org/sage into cubic_braid_group_27302

@soehms
Copy link
Member Author

soehms commented Mar 29, 2019

comment:6

Fixed merge conflict!

@soehms
Copy link
Member Author

soehms commented Mar 29, 2019

Author: Sebastian Oehms

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

76a845e27302: fixed doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2019

Changed commit from 6b638b4 to 76a845e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

3402ba727302: python3 fixes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2019

Changed commit from 76a845e to 3402ba7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2019

Changed commit from 3402ba7 to 4b96740

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

4b9674027302: further corrections according to patchbot hints

@fchapoton
Copy link
Contributor

comment:10

Some random remarks:

typo "refelection"

typo "Vancover"

burau >>> Burau

typo "availlable"

typo "as_permutatopn_group"

Use "Construct" and "Return" in the first lines of doc, not "Constructs" and "Returns"

"len(root_list) == 0" could be "not(root_list)" which is faster

+    TESTS:
+
+        sage: C3 = CubicBraidGroup(3)

is missing a double ::

range(0, n-3) >>> range(n - 3)

In

+            if m % 2  == 0:
+                mhalf = m/2
+            else:
+                mhalf = (m-1)/2

rather use exact division //

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 2, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

116415627302: typo and style fixes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 2, 2019

Changed commit from 4b96740 to 1164156

@soehms
Copy link
Member Author

soehms commented Apr 2, 2019

comment:12

Replying to @fchapoton:

Some random remarks:
...

Thanks for having a look at this!

@fchapoton
Copy link
Contributor

comment:13

two more:

typo: hermitain

typo: performace

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

46a013427302: spell-check performed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2019

Changed commit from 1164156 to 46a0134

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

8375891Merge branch 'u/soehms/cubic_braid_group_27302' of git://trac.sagemath.org/sage into cubic_braid_groups_27302
fe4adff27302: comparison for larger groups fixed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2019

Changed commit from 24c1d06 to fe4adff

@soehms
Copy link
Member Author

soehms commented Aug 11, 2019

comment:27

While developing a class for cubic Hecke algebras I observed that comparison for cubic braids on more than 5 strands didn't terminate (since the implementation from the finitely presented groups was used). So, I replaced that comparison for the groups on more than 5 strands by comparison of the corresponding braids resp. the Burau-matrix of the cubic braid.

The default setting for the characteristic of the Burau-matrix was implemented in the as_matrix_group method, which is not the right place. I fixed that, as well.

@fchapoton
Copy link
Contributor

comment:28

patchbot's pyflakes-plugin reports an unused import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2019

Changed commit from fe4adff to 4ea9263

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

4ea9263Merge branch 'u/soehms/cubic_braid_group_27302' of git://trac.sagemath.org/sage into cubic_braid_group_27302

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

6663fa727302: add methods `__init__`, `__hash__`,and `_matrix_` to the element class

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2019

Changed commit from 4ea9263 to 6663fa7

@soehms
Copy link
Member Author

soehms commented Sep 17, 2019

comment:31

I do the following:

  • fix pyflakes
  • add method __hash__ to the element class, since the inherited version is not well defined
  • add method _matrix_ to the element class as an alternative to the default of burau_matrix with better performance properties.
  • add method __init__ to the element class to perform a reduction on the Tietze-tuple.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 19, 2019

Changed commit from 6663fa7 to db5b7a7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 19, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

2de6f71Merge branch 'u/soehms/cubic_braid_group_27302' of git://trac.sagemath.org/sage into cubic_braid_group_27302
db5b7a727302: some cleaning in burau_matrix

@soehms soehms modified the milestones: sage-8.9, sage-9.0 Oct 19, 2019
@fchapoton
Copy link
Contributor

comment:34

now the branch is red

@fchapoton
Copy link
Contributor

Changed dependencies from #25894 to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 9, 2019

Changed commit from db5b7a7 to 9fdafdd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 9, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

9fdafddMerge branch 'u/soehms/cubic_braid_group_27302' of git://trac.sagemath.org/sage into cubic_braid_group_27302

@soehms
Copy link
Member Author

soehms commented Nov 9, 2019

comment:36

Merge error in references index.rst fixed

@fchapoton
Copy link
Contributor

comment:37

ok, let it be. One can keep further enhancement for later tickets.

@fchapoton
Copy link
Contributor

Reviewer: Travis Scrimshaw, Frédéric Chapoton

@soehms
Copy link
Member Author

soehms commented Nov 13, 2019

comment:38

Thanks!

@vbraun
Copy link
Member

vbraun commented Nov 16, 2019

Changed branch from u/soehms/cubic_braid_group_27302 to 9fdafdd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants