Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sqlite3 to 3.27.1 #27303

Closed
EmmanuelCharpentier mannequin opened this issue Feb 16, 2019 · 11 comments
Closed

Upgrade sqlite3 to 3.27.1 #27303

EmmanuelCharpentier mannequin opened this issue Feb 16, 2019 · 11 comments

Comments

@EmmanuelCharpentier
Copy link
Mannequin

EmmanuelCharpentier mannequin commented Feb 16, 2019

Rationale : see this sage-devel post and its followup.

Tarball : https://sqlite.org/2019/sqlite-autoconf-3270100.tar.gz

CC: @kiwifb

Component: packages: standard

Author: Emmanuel Charpentier

Branch: 09ae5f1

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27303

@EmmanuelCharpentier EmmanuelCharpentier mannequin added this to the sage-8.7 milestone Feb 16, 2019
@kiwifb kiwifb changed the title Upgrade sqlite3 to 2.27.1 Upgrade sqlite3 to 3.27.1 Feb 16, 2019
@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Feb 16, 2019

Branch: u/charpent/upgrade_sqlite3_to_3_27_1

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Feb 16, 2019

comment:3

Builds without a hitch. ptestlong gives one permanent failure :

----------------------------------------------------------------------
sage -t --long --warn-long 154.5 src/sage/libs/giac.py  # 3 doctests failed
----------------------------------------------------------------------

which is identical in all details to the one already reported before this patch.

==> needs_review


New commits:

09ae5f1sqlite : Drop new sources in place.

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Feb 16, 2019

Commit: 09ae5f1

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Feb 16, 2019

Author: Emmanuel Charpentier

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Feb 16, 2019

comment:4

Replying to @EmmanuelCharpentier:

Note that this doesn not fix my original issue, which is attributable to another (yet unknown) problem...

@tscrim
Copy link
Collaborator

tscrim commented Feb 16, 2019

comment:5

Still good to update this. To the buildbots it goes.

@tscrim
Copy link
Collaborator

tscrim commented Feb 16, 2019

Reviewer: Travis Scrimshaw

@kiwifb
Copy link
Member

kiwifb commented Feb 16, 2019

comment:6

Replying to @EmmanuelCharpentier:

Replying to @EmmanuelCharpentier:

Note that this doesn not fix my original issue, which is attributable to another (yet unknown) problem...

I guess you may have solved the first failure out of many. What's next?

@vbraun
Copy link
Member

vbraun commented Feb 22, 2019

Changed branch from u/charpent/upgrade_sqlite3_to_3_27_1 to 09ae5f1

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Feb 27, 2019

comment:8

Replying to @kiwifb:

Replying to @EmmanuelCharpentier:

Replying to @EmmanuelCharpentier:

Note that this doesn not fix my original issue, which is attributable to another (yet unknown) problem...

I guess you may have solved the first failure out of many. What's next?

Nothing "reasonable" that I've tried worked : it seems that using the library entails the use of configuration executables which have the library path hardcoded, or possibly vice-versa.

So I went unreasonable an installed the library from source via sage -sh under $SAGE_LOCAL. This worked. And is a pain in the *ss...

Thanks for your help !

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Feb 27, 2019

Changed commit from 09ae5f1 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants