Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: partial care for matrix/ #27317

Closed
fchapoton opened this issue Feb 18, 2019 · 9 comments
Closed

py3: partial care for matrix/ #27317

fchapoton opened this issue Feb 18, 2019 · 9 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@fchapoton
Copy link
Contributor

inluding fixing one bad range

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 4ac9c1f

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/27317
@fchapoton fchapoton added this to the sage-8.7 milestone Feb 18, 2019
@fchapoton
Copy link
Contributor Author

Commit: e6d2fcc

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27317

@dcoudert
Copy link
Contributor

comment:2

I know it's only for py3 compatibility, but wouldn't it be better in this case to compute the maxrest_order) before ?

+            j = min(ind for ind in range(len(rest_order))
+                    if rest_order[ind] == max(rest_order))

Otherwise, looks good to me.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

4ac9c1ftrac 27317 more efficient code

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2019

Changed commit from e6d2fcc to 4ac9c1f

@fchapoton
Copy link
Contributor Author

comment:4

Voilà, voilà. Avec quelques autres petites améliorations autour..

@dcoudert
Copy link
Contributor

comment:5

LGTM.

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@vbraun
Copy link
Member

vbraun commented Feb 23, 2019

Changed branch from u/chapoton/27317 to 4ac9c1f

@vbraun vbraun closed this as completed in b83b2ef Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @dcoudert