Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update git-trac instructions in developer's guide #27340

Closed
kevindilks mannequin opened this issue Feb 22, 2019 · 10 comments
Closed

Update git-trac instructions in developer's guide #27340

kevindilks mannequin opened this issue Feb 22, 2019 · 10 comments
Labels
c: documentation p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@kevindilks
Copy link
Mannequin

kevindilks mannequin commented Feb 22, 2019

Instructions for git-trac-command in the Developer's Guide needs to be updated to match the instructions and new options listed on the Readme of the git-trac-command GitHub page.

In particular, the Developer's Guide makes no mention of the new --token= option, which is the only way that people with GitHub accounts are able to authenticate.

CC: @slel

Component: documentation

Author: Kevin Dilks

Branch/Commit: 1a5324a

Reviewer: Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/27340
@kevindilks kevindilks mannequin added this to the sage-8.7 milestone Feb 22, 2019
@kevindilks
Copy link
Mannequin Author

kevindilks mannequin commented Feb 22, 2019

Branch: u/kdilks/gittrac27340

@slel

This comment has been minimized.

Sign in to view
@slel
Copy link
Member

slel commented Feb 25, 2019

comment:2

Don't forget to set the ticket to needs_review when it is ready for review.

New commits:

1a5324aAdded new documentation

@slel
Copy link
Member

slel commented Feb 25, 2019

Commit: 1a5324a

@slel
Copy link
Member

slel commented Feb 25, 2019

comment:3

Also, add your full name in the "Author" field.

@kevindilks
Copy link
Mannequin Author

kevindilks mannequin commented Feb 25, 2019

comment:4

I know, I just didn't want to mark it for review until I had a chance to double-check everything myself.

@kevindilks
Copy link
Mannequin Author

kevindilks mannequin commented Feb 25, 2019

Author: Kevin Dilks

@kevindilks kevindilks mannequin added the s: needs review label Feb 25, 2019
@slel

This comment has been minimized.

Sign in to view
@slel
Copy link
Member

slel commented Feb 25, 2019

Reviewer: Samuel Lelièvre

@vbraun
Copy link
Member

vbraun commented Feb 26, 2019

Changed branch from u/kdilks/gittrac27340 to 1a5324a

@vbraun vbraun closed this as completed in 22b485e Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
2 participants
@vbraun @slel