Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for dsage doctest failures in sage-2.11.rc0 #2736

Closed
yqiang mannequin opened this issue Mar 30, 2008 · 2 comments
Closed

fix for dsage doctest failures in sage-2.11.rc0 #2736

yqiang mannequin opened this issue Mar 30, 2008 · 2 comments
Assignees
@yqiang
Labels
c: dsage p: major / 3 t: bug
Milestone
sage-2.11

Comments

@yqiang
Copy link
Mannequin

yqiang mannequin commented Mar 30, 2008

Attached is a patch which fixes the annoying exceptions thrown by the doctest runner at the end of the dsage doctests.

This patch does the following:

  1. Explicitly call .wait() on subprocess.Popen instances
  2. Explicitly delete the reference to the Popen instances before letting the interpreter exit
  3. Explicitly join the dsage thread before letting the interpreter exit in the doctest.

Component: dsage

Issue created by migration from https://trac.sagemath.org/ticket/2736
@yqiang yqiang mannequin added this to the sage-2.11 milestone Mar 30, 2008
@yqiang yqiang mannequin added c: dsage labels Mar 30, 2008
@yqiang yqiang mannequin self-assigned this Mar 30, 2008
@yqiang yqiang mannequin added the s: needs review label Mar 30, 2008
@williamstein
Copy link
Contributor

comment:1

Attachment: dsage_doctest_threading.patch.gz

Tested on OS X.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 30, 2008

comment:2

Merged in Sage 2.11.final

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Mar 30, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yqiang yqiang

Labels
c: dsage p: major / 3 t: bug
Projects
None yet
Milestone
sage-2.11
Development

No branches or pull requests
1 participant
@williamstein