Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of -valgrind/--valgrind in doctesting is broken #27381

Closed
strogdon opened this issue Feb 27, 2019 · 7 comments
Closed

Use of -valgrind/--valgrind in doctesting is broken #27381

strogdon opened this issue Feb 27, 2019 · 7 comments

Comments

@strogdon
Copy link

As reported here

./sage -t --long --valgrind "doctest"

appears to be broken. For example

./sage -t --long --valgrind src/sage/combinat/tableau.py

retuns one to the shell prompt and in ~/.sage/valgrind/sage-memcheck.8525 there is

==8525== Memcheck, a memory error detector
==8525== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==8525== Using Valgrind-3.14.0 and LibVEX; rerun with -h for copyright info
==8525== Command: python /64bitdev/storage/sage-git_develop/sage/local/bin/sage-runtests --serial --long --timeout=172800 --memlimit=3300 --stats_path=/home/volj/27/strogdon/.sage/timings2.json --optional=dochtml,memlimit,mpir,python2,sage src/sage/combinat/tableau.py
==8525== Parent PID: 8495
==8525==
==8525== FATAL: can't open suppressions file "/64bitdev/storage/sage-git_develop/sage/local/lib/valgrind/sage.supp"

So the suppressions files cannot be located.

Component: doctest framework

Keywords: valgrind

Author: Steven Trogdon

Branch/Commit: bece276

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/27381

@strogdon
Copy link
Author

Branch: u/strogdon/valgrind

@strogdon
Copy link
Author

comment:2

The suppressions files are now located under $SAGE_EXTCODE/valgrind instead of under $SAGE_LOCAL/lib/valgrind. I have included all of the available suppressions files and one line in control.py was changed so the doctest would pass.


New commits:

bece276changes to control.py

@strogdon
Copy link
Author

Commit: bece276

@strogdon
Copy link
Author

Author: Steven Trogdon

@kiwifb
Copy link
Member

kiwifb commented Feb 27, 2019

Reviewer: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Feb 27, 2019

comment:4

The suppression files have been moved there by Volker at sage-6.4.beta5. But control.py didn't follow. Incredibly some of it should have been picked up in https://github.com/sagemath/sage-prod/commit/59af6983b05b6581ef1282cdec41d6e63ad82459 in sage-6.8.beta4 if valgrind had been tested then.

@vbraun
Copy link
Member

vbraun commented Mar 2, 2019

Changed branch from u/strogdon/valgrind to bece276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants