Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance conversion of sparse matrices to magma #27382

Closed
fchapoton opened this issue Feb 28, 2019 · 10 comments
Closed

enhance conversion of sparse matrices to magma #27382

fchapoton opened this issue Feb 28, 2019 · 10 comments
Labels
c: interfaces: optional p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@fchapoton
Copy link
Contributor

CC: @sagetrac-pguillot

Component: interfaces: optional

Author: Frédéric Chapoton

Branch/Commit: 8dd4dd3

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27382
@fchapoton fchapoton added this to the sage-8.7 milestone Feb 28, 2019
@fchapoton
Copy link
Contributor Author

Commit: b79a861

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27382

@fchapoton
Copy link
Contributor Author

comment:1

not yet tested, and one should add examples

New commits:

b79a861trac 27382 first tentative

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 28, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8dd4dd3trac 27382 better conversion of sparse matrix to magma

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 28, 2019

Changed commit from b79a861 to 8dd4dd3

@fchapoton
Copy link
Contributor Author

comment:3

now working and doctested

@fchapoton
Copy link
Contributor Author

Author: Frédéric Chapoton

@tscrim
Copy link
Collaborator

tscrim commented Feb 28, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 28, 2019

comment:6

LGTM.

@vbraun
Copy link
Member

vbraun commented Mar 3, 2019

Changed branch from u/chapoton/27382 to 8dd4dd3

@vbraun vbraun closed this as completed in 45aa76c Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces: optional p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton