Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify or fix ideal mod in SR #27401

Open
kcrisman opened this issue Mar 3, 2019 · 3 comments
Open

Clarify or fix ideal mod in SR #27401

kcrisman opened this issue Mar 3, 2019 · 3 comments

Comments

@kcrisman
Copy link
Member

kcrisman commented Mar 3, 2019

See this SO question.

        from sage.rings.ideal import is_Ideal
        if not is_Ideal(I) or not I.ring() is self._parent:
            I = self._parent.ideal(I)
            #raise TypeError, "I = %s must be an ideal in %s"%(I, self.parent())
        return I.reduce(self)

Why the commented error? Was that supposed to be raised in certain cases?

Anyway, the real problem (if it's a problem) is here:

sage: I = SR.ideal(x)
sage: I.reduce??
...
return f       # default

Well.

Component: symbolics

Issue created by migration from https://trac.sagemath.org/ticket/27401

@kcrisman kcrisman added this to the sage-8.7 milestone Mar 3, 2019
@kcrisman
Copy link
Member Author

kcrisman commented Mar 3, 2019

comment:1

(By the way, I recognize that this may not really be 'fixable' given that the symbolic ring isn't really one, but at least we can perhaps have a warning - or even raise a NotImplementedError for SR, as this is the sort of silent behavior that causes trouble. If f(x)=x^2, then both f(3).mod(7) and f(x+1).mod(x) give something that might cause nasty sorts of bugs. I don't think we can call this solely user error if someone runs into trouble here.)

@embray
Copy link
Contributor

embray commented Mar 25, 2019

comment:2

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

@embray embray modified the milestones: sage-8.7, sage-8.8 Mar 25, 2019
@embray
Copy link
Contributor

embray commented Jun 14, 2019

comment:3

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

@embray embray removed this from the sage-8.8 milestone Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants