Don't use bare except: statements

[jdemeyer]

It's well known that except: should be avoided because it catches unintended things like KeyboardInterrupt.

Component: misc

Author: Jeroen Demeyer

Branch: 367b0a1

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/27427

[jdemeyer]

Branch: u/jdemeyer/don_t_use_base_except__statements

[jdemeyer]

New commits:

cfcded7

Fix bare "except:" statements

[jdemeyer]

Commit: cfcded7

[fchapoton]

comment:4

some failing doctests in inverse doctests, see patchbot

[tscrim]

comment:5

Seems like the failures are from the change in rings/valuation/valuation_space.py.

[fchapoton]

comment:6

This is because _test_inverse in the same file is ignoring the NotImplementedError cases only.

[jdemeyer]

comment:7

Replying to @fchapoton:

This is because _test_inverse in the same file is ignoring the NotImplementedError cases only.

That's wrong: inverting a non-invertible element shouldn't raise NotImplementedError.

[sagetrac-git]

Changed commit from cfcded7 to 0104d64

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0104d64

Fix bare "except:" statements

[tscrim]

comment:10

I think the code in matrix_gps should catch a ValueError as the is_positive_definite() will fail with one when the matrix (group) is defined over a field without an embedding into C.

[fchapoton]

comment:11

doctests on inverse are still not fixed

[jdemeyer]

comment:12

Sorry for the mess, I'm doing too many things at the same time.

[jdemeyer]

comment:13

Replying to @fchapoton:

doctests on inverse are still not fixed

Are you sure? I ran all tests in src/sage/rings and it worked fine.

(edit: never mind, I ran all tests without --long and the failing ones all have # long time)

[fchapoton]

comment:14

pathcbots say that long test fails on 0104d64536e08abf61b4e

[sagetrac-git]

Changed commit from 0104d64 to 78ed09c

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

78ed09c

Fix bare "except:" statements

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

367b0a1

Fix bare "except:" statements

[sagetrac-git]

Changed commit from 78ed09c to 367b0a1

[jdemeyer]

comment:17

I think that this fixes all comments. I decided to make some changes to the handling of matrix groups, printing "positive definite" when it is positive definite (previously, it only printed "non positive definite").

[jdemeyer]

comment:18

Note that the other places where I removed a try/except block was with code of the form

try:
    ...
except:
    raise ...

In general, I don't like this code structure, I prefer the keep the original exception (which often contains more useful information).

[fchapoton]

Reviewer: Frédéric Chapoton

[fchapoton]

comment:19

ok, let it be..

[vbraun]

Changed branch from u/jdemeyer/don_t_use_base_except__statements to 367b0a1

[soehms]

comment:21

Thanks Jeroen, for correcting my mistakes!
Thanks Travis and Frédéric for your help on that!

[soehms]

Changed commit from 367b0a1 to none