Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some little code cleanup #27429

Closed
fchapoton opened this issue Mar 5, 2019 · 6 comments
Closed

some little code cleanup #27429

fchapoton opened this issue Mar 5, 2019 · 6 comments
Labels
c: geometry p: minor / 4 t: enhancement
Milestone
sage-8.7

Comments

@fchapoton
Copy link
Contributor

in two files, one about polyhedron, the other about toric varieties

various changes, for cleanness, speed or pep8

Component: geometry

Author: Frédéric Chapoton

Branch/Commit: 86fabb7

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27429
@fchapoton fchapoton added this to the sage-8.7 milestone Mar 5, 2019
@fchapoton
Copy link
Contributor Author

Commit: 86fabb7

@fchapoton
Copy link
Contributor Author

New commits:

86fabb7some little code cleanup of two unrelated files

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27429

@tscrim
Copy link
Collaborator

tscrim commented Mar 5, 2019

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Mar 5, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Mar 6, 2019

Changed branch from u/chapoton/27429 to 86fabb7

@vbraun vbraun closed this as completed in 063963f Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton