Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fix last doctest in mutable_poset #27433

Closed
fchapoton opened this issue Mar 7, 2019 · 10 comments
Closed

py3: fix last doctest in mutable_poset #27433

fchapoton opened this issue Mar 7, 2019 · 10 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: e7568f1

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27433
@fchapoton fchapoton added this to the sage-8.7 milestone Mar 7, 2019
@fchapoton
Copy link
Contributor Author

New commits:

9dc622dpy3: fix last doctest in mutable_poset

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27433

@fchapoton
Copy link
Contributor Author

Commit: 9dc622d

@fchapoton
Copy link
Contributor Author

comment:2

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Mar 7, 2019

comment:3

I think the alignment that was in the original doctest was helpful (sorry to nitpick about something trivial). Once changed or if you don't care enough to add it back in, you can set a positive review.

@tscrim
Copy link
Collaborator

tscrim commented Mar 7, 2019

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2019

Changed commit from 9dc622d to e7568f1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

e7568f1trac 27433 reviewer request : align

@fchapoton
Copy link
Contributor Author

comment:5

done, thx

@vbraun
Copy link
Member

vbraun commented Mar 8, 2019

Changed branch from u/chapoton/27433 to e7568f1

@vbraun vbraun closed this as completed in fe0269a Mar 8, 2019
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton