Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Link to PRESENT paper #27436

Closed
yhxnf opened this issue Mar 7, 2019 · 13 comments
Closed

Update Link to PRESENT paper #27436

yhxnf opened this issue Mar 7, 2019 · 13 comments
Labels
c: documentation p: trivial / 5 t: bug
Milestone
sage-8.7

Comments

@yhxnf
Copy link

yhxnf commented Mar 7, 2019

The old link is dead (404).

Component: documentation

Author: Lukas Stennes

Branch/Commit: 2c34056

Reviewer: Friedrich Wiemer, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/27436
@yhxnf yhxnf added this to the sage-8.7 milestone Mar 7, 2019
@pfasante
Copy link

pfasante commented Mar 7, 2019

comment:2

LGTM

@pfasante
Copy link

pfasante commented Mar 7, 2019

Reviewer: Friedrich Wiemer

@fchapoton
Copy link
Contributor

comment:3

you should rather use the doi role :doi:`454545-4564-65456`

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

530e558use doi role

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2019

Changed commit from c157b1f to 530e558

@dcoudert
Copy link
Contributor

dcoudert commented Mar 7, 2019

comment:7

one space missing in alignment

             Springer Verlag 2007; available at
-	    :doi:`10.1007/978-1-4419-5906-5_605`
+	     :doi:`10.1007/978-1-4419-5906-5_605`

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2019

Changed commit from 530e558 to 2c34056

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

2c34056fixed alignment

@fchapoton
Copy link
Contributor

comment:9

Error: TAB character found at line 473

@yhxnf
Copy link
Author

yhxnf commented Mar 7, 2019

comment:10

Replying to @fchapoton:

Error: TAB character found at line 473

fixed in ​last commit

@fchapoton
Copy link
Contributor

Changed reviewer from Friedrich Wiemer to Friedrich Wiemer, Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:11

ok

@vbraun
Copy link
Member

vbraun commented Mar 13, 2019

Changed branch from u/gh-yhxnf/fix_link_present_paper to 2c34056

@vbraun vbraun closed this as completed in 1e2dc5b Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: trivial / 5 t: bug
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
5 participants
@vbraun @pfasante @fchapoton @dcoudert @yhxnf