Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx_plot: Fix regression for 3d plots, suppress axes frame #27481

Closed
mkoeppe opened this issue Mar 14, 2019 · 11 comments
Closed

sphinx_plot: Fix regression for 3d plots, suppress axes frame #27481

mkoeppe opened this issue Mar 14, 2019 · 11 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Mar 14, 2019

As reported in https://groups.google.com/forum/#!topic/sage-devel/qivRW2D2Fgg

CC: @egourgoulhon

Component: documentation

Author: Matthias Koeppe

Branch/Commit: 013415d

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/27481

@mkoeppe mkoeppe added this to the sage-8.7 milestone Mar 14, 2019
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 14, 2019

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 14, 2019

Commit: 013415d

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 14, 2019

New commits:

013415dsphinx_plot: For 3d objects plotted via png, turn off axes frame

@egourgoulhon
Copy link
Member

comment:3

Thanks for the fix! Is the ticket ready for review?

@embray
Copy link
Contributor

embray commented Mar 14, 2019

comment:4

I'd say this is pretty important since without it there's a noticeable, if not mostly aesthetic, regression in the documentation.

@egourgoulhon
Copy link
Member

comment:5

Replying to @egourgoulhon:

Thanks for the fix! Is the ticket ready for review?

I've checked the ticket branch: it fixes the issue. So I am ready to give a 'positive review', all the more that the release of 8.7.rc0 is approaching... If you agree, please set the ticket to 'needs review'.

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 15, 2019

Author: Matthias Koeppe

@egourgoulhon
Copy link
Member

comment:7

Thanks!

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@embray
Copy link
Contributor

embray commented Mar 25, 2019

comment:8

Moving all blocker/critical issues from 8.7 to 8.8.

@embray embray modified the milestones: sage-8.7, sage-8.8 Mar 25, 2019
@vbraun
Copy link
Member

vbraun commented Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants