Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cygwin: OpenBLAS doesn't read environment variables properly #27493

Closed
embray opened this issue Mar 15, 2019 · 7 comments
Closed

Cygwin: OpenBLAS doesn't read environment variables properly #27493

embray opened this issue Mar 15, 2019 · 7 comments

Comments

@embray
Copy link
Contributor

embray commented Mar 15, 2019

In Sage we currently, by default, disable multithreading in OpenBLAS by setting OPENBLAS_NUM_THREADS=1 in sage-env.

While this is not ideal, it does reduce the likelihood of multithreading issues coming up in contexts where it wasn't explicitly requested.

While investigating #27434, I found that there is a subtle and apparently rare bug in OpenBLAS's multithreading on Windows, which was causing the docbuild to hang, particularly while building the plot3d docs (which happen to exercise this area of the code more than anything else in Sage).

It occurred to me, however, that the docbuild should not be exhibiting the bug since we set OPENBLAS_NUM_THREADS=1. It turns out this is due to a bug in OpenBLAS on Cygwin, fixed by the attached patch.

I'm setting this to "critical" since it would be very good to have this fixed for the buildbot. I think this bug has been affecting Cygwin for a long time, but I could never nail down why. Nevertheless since we have lived with this bug thus far I won't consider it a blocker.

Upstream PR: OpenMathLib/OpenBLAS#2060

Upstream: Fixed upstream, but not in a stable release.

Component: porting: Cygwin

Author: Erik Bray

Branch/Commit: abe0d27

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/27493

@embray embray added this to the sage-8.7 milestone Mar 15, 2019
@embray
Copy link
Contributor Author

embray commented Mar 15, 2019

New commits:

abe0d27Trac #27493: Patch OpenBLAS to read environment variables properly on

@embray
Copy link
Contributor Author

embray commented Mar 15, 2019

Commit: abe0d27

@embray
Copy link
Contributor Author

embray commented Mar 15, 2019

Branch: u/embray/ticket-27493

@embray
Copy link
Contributor Author

embray commented Mar 18, 2019

Upstream: Fixed upstream, but not in a stable release.

@embray
Copy link
Contributor Author

embray commented Mar 25, 2019

comment:3

Moving all blocker/critical issues from 8.7 to 8.8.

@embray embray modified the milestones: sage-8.7, sage-8.8 Mar 25, 2019
@vbraun
Copy link
Member

vbraun commented Apr 4, 2019

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Apr 5, 2019

Changed branch from u/embray/ticket-27493 to abe0d27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants